-
Notifications
You must be signed in to change notification settings - Fork 3.4k
Use 64-bit fields for fsblkcnt_t and fsfilcnt_t #24769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
We were running into issues where some of our bots were reporting numbers larger than 2^32 when calling statfs on the underlying filesystem.
Note that this is an ABI break. Rust had a lot of issues with the previous stat-related ABI break, see e.g. #19569 (comment) and rust-lang/rust#131467. Though, I haven't yet verified whether the same applies to the |
True, that is why I mention in the ChangeLog. Note that we don't (currently) make any guarantees that object files and libraries built with one version of emscripten can be used by another version. |
Maybe lets land this first, then the new |
Grepping for these structs in Rust returned no results, so it's likely/hopefully safe. |
We were running into issues where some of our bots were reporting numbers larger than 2^32 when calling statfs on the underlying filesystem.