Skip to content
This repository was archived by the owner on Aug 19, 2025. It is now read-only.

Conversation

aminalaee
Copy link
Contributor

Dropping Python3.6 and setting minimum version to Python 3.7

@aminalaee aminalaee linked an issue Feb 1, 2022 that may be closed by this pull request
@aminalaee aminalaee mentioned this pull request Feb 1, 2022
@collerek
Copy link
Contributor

collerek commented Feb 7, 2022

@aminalaee This requires changes in checks - 3.6. should be removed from required runs.

@aminalaee
Copy link
Contributor Author

The checks are updated for future PRs but since this PR's base branch has that check I think only the maintainer access can merge this. Maybe @tomchristie can help here.

@collerek
Copy link
Contributor

The checks are updated for future PRs but since this PR's base branch has that check I think only the maintainer access can merge this. Maybe @tomchristie can help here.

Yep, I believe you need access to settings -> branches to disable it.
So we indeed need @tomchristie help with that.
Maybe disable all of them, we don't merge anything that fails any of the runs anyway?

@aminalaee aminalaee mentioned this pull request May 29, 2022
@collerek
Copy link
Contributor

@Kludex can you adjust the settings of this repository and uncheck the required checks status in the branches settings of databases? We cannot merge it since it stills requires python 3.6 check for a branch that removes it.

@aminalaee
Copy link
Contributor Author

@collerek He mentioned in gitter that only @tomchristie can do that

@collerek
Copy link
Contributor

Ah, ok. Saw the operations group in encode and by the description I thought all members can manage repository settings

@aminalaee aminalaee merged commit 17b03a4 into master May 30, 2022
@aminalaee aminalaee deleted the drop-python3.6 branch May 30, 2022 10:32
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Removing Python 3.6
3 participants