Fixed #5363 -- HTML5 datetime-local valid format HTMLFormRenderer #9365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @auvipy! Following your comment on #5363 (comment) I ask if you could do the review! Thank you! |
peterthomassen
requested changes
Jun 10, 2024
rest_framework/renderers.py
Outdated
| # The format of an input type="datetime-local" is "yyyy-MM-ddThh:mm" | ||
| # followed by optional ":ss" or ":ss.SSS", so remove [milli|micro]seconds | ||
| # to avoid browser error. | ||
| field.value = "".join(field.value.rstrip('Z').split(".")[:1]) |
There was a problem hiding this comment.
The millisecond part should be retained, as it's a valid part of the format.
There was a problem hiding this comment.
I finally did it! Thanks for the pacience!
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
auvipy
reviewed
Apr 28, 2025
|
Thanks @auvipy! I'll do it! |
|
Just an update here. I'm still active! I'll do as soon as possible |
| class TestDateTimeFieldHTMLFormRender(TestCase): | ||
| def test_datetime_field_rendering(self): | ||
| class TestSerializer(serializers.Serializer): | ||
| appointment = serializers.DateTimeField() |
There was a problem hiding this comment.
Liked this anonymous class 👍🏻
|
I finally did it, sorry for the long delay! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Hi!
This PR delete everything after the first 3 digits of the miliseconds part of a
DateTimeFieldinput atHTMLFormRendererto avoid break in browsers:https://developer.mozilla.org/en-US/docs/Web/HTML/Reference/Elements/input/datetime-local#try_it
refs #5363