Skip to content

Conversation

@ulgens
Copy link
Contributor

@ulgens ulgens commented Nov 2, 2025

It was defined in testenv.deps for tox, making it a literal testing requirement. The version requirement is copied from pyproject.toml.

This change helps with the local testing, in a similar way to #9817 does. Because setuptools dependency was only defined for tox, the recommended testing method in https://www.django-rest-framework.org/community/contributing/#testing

# Setup the virtual environment
python3 -m venv env
source env/bin/activate
pip install -e .
pip install -r requirements.txt

# Run the tests
./runtests.py

were skipping coreapi related tests.

@ulgens ulgens force-pushed the move-setuptools-testing-requirements branch from f55e8b9 to 1a88ae5 Compare November 2, 2025 11:53
It was defined in `testenv.deps` for tox, making it a literal testing requirement. The version requirement is copied from `pyproject.toml`.
@ulgens ulgens force-pushed the move-setuptools-testing-requirements branch from 1a88ae5 to c096d18 Compare November 2, 2025 12:02
@auvipy auvipy requested a review from browniebroke November 2, 2025 12:12
@browniebroke
Copy link
Collaborator

Do we need it at all? I would have thought we could remove it entirely but maybe it's needed by one of our deps?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants