set window coord as UNDEFINED only if x||y==-1#185
Open
korrectional wants to merge 6 commits into
Open
Conversation
Author
|
TwilitRealm/dusklight#1238 this is the PR in dustlight which depends on this PR. |
encounter
reviewed
May 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stopped window coordinates from being set as SDL_WINDOWPOS_UNDEFINED and instead only do so when x or y are equal to -1. This is done because of another PR (will put link below) in the dusklight project to remember window positions upon close. When a window is to the left of the main monitor, the x coordinate becomes negative and hence the need to allow for negative coordinates in Aurora.