fix(check): remove dangling links when fixing dead nodes#4
Merged
Conversation
--fix only filtered meta.nodes, leaving links that pointed at removed nodes. On reload Workflow.fromJSON threw LinkValidationError, so check stayed red after fix. Now also filter meta.links by valid node ids. build with cc
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
light check --fixonly filteredmeta.nodes, leaving links pointing at removed nodesWorkflow.fromJSONthrewLinkValidationError, so check stayed red after--fixmeta.linksagainst the set of still-valid node ids, and reports the countTest plan
npm run buildnpm test(113 passing)light check <dir> --fix, verify check is green and links referencing the removed node are gone fromworkflow.json