-
Notifications
You must be signed in to change notification settings - Fork 334
Moving polyglot java import
handling into EpbLanguage
#13483
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoContext.java
Outdated
Show resolved
Hide resolved
Jaroslav Tulach reports a new STANDUP for yesterday (2025-07-17): Progress: .
|
With 67d8c11 I see to be able to change the enso$ ENSO_LAUNCHER=native,-ls,fast sbt buildEngineDistribution
enso$ ./enso --vm.D=polyglot.enso.classLoading=guest --run test/Generic_JDBC_Tests/
20 tests succeeded.
2 tests failed.
0 tests skipped.
0 groups skipped.
Failed tests: 'should.handle.SQL.errors' e.g. the dual JVM mode is almost working for |
Jaroslav Tulach reports a new STANDUP for yesterday (2025-07-18): Progress: .
|
import org.junit.After; | ||
import org.junit.Test; | ||
|
||
/** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to point attention of everyone and primarily libraries team, e.g. @jdunkerley, @GregoryTravis, @AdRiley to this test.
- should there be any inconsistencies between hosted mode (used so far) and guest mode (the dual JVM mode), then this suite will demonstrate them
- add a new
@Test
into thisJavaInteropTest
file - execute as
runtime-integration-tests/testOnly *JavaInteropTest
- the test gets executed in both configurations
- failing in one of the configurations nicely demonstrates differences in implementation
Please remind yourself of this testing infrastructure when you see misbehavior of polyglot java import
with/without --jvm
mode or in dual JVM mode. Should you have any questions, please ask now or in the future.
polyglot java import
handling functionality into EpbLanguage
polyglot java import
handling functionality into EpbLanguage
polyglot java import
handling into EpbLanguage
edce6ba
to
62aaafe
Compare
Future: Make it Faster!Executing
Future work is to extract these queries and perform them before serializing |
Jaroslav Tulach reports a new STANDUP for yesterday (2025-07-21): Progress: .
|
Pull Request Description
Making
EpbLanguage
the central place to deal with foreign and polyglot Enso statements. Moving all the JVM class loading functionality intoruntime-language-epb
module. Being a language, theEpbLanguage
is better suited for entering/leavingTruffleContext
instances than regular code that only usesorg.graalvm.polyglot
API.Opt-in with
polyglot.enso.classLoading=guest
for this dual JVM execution mode. Use for example:$ ENSO_LAUNCHER=native,-ls,fast sbt sbt:enso> runEngineDistribution --vm.D=polyglot.enso.classLoading=guest --run test/Generic_JDBC_Tests 22 tests succeeded. 0 tests failed. 0 tests skipped. 0 groups skipped.
to execute 100%
test/Generic_JDBC_Tests
in this dual JVM execution mode. Subsequent PRs will continue towards making this execution mode the default.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,