Bump Google java format version to 1.28.0 #14038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Akirathan
added
the
CI: No changelog needed
Akirathan
requested review from
4e6,
AdRiley,
GregoryTravis,
JaroslavTulach,
hubertp and
jdunkerley
as code owners
GregoryTravis
approved these changes
Sep 22, 2025
AdRiley
approved these changes
Sep 22, 2025
hubertp
approved these changes
Sep 22, 2025
JaroslavTulach
approved these changes
Sep 23, 2025
| var code = | ||
| """ | ||
| from Standard.Base import all | ||
| from Standard.Base import all |
There was a problem hiding this comment.
Yeah, somebody fixed the formatting of the text blocks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This blocks #14019
Pull Request Description
#14019 is blocked by this - the current google java format version is failing because it tries to call remove method from JDK - see https://github.com/enso-org/enso/actions/runs/17916525266/job/50940077628?pr=14019#step:5:245
Important Notes
The only notable change is in ff3fec5 . Every thing else is just automatic
sbt javafmtAllformatting.Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.