Avoid Semaphore and TruffleSafepoint
#14521
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JaroslavTulach
added
the
CI: No changelog needed
JaroslavTulach
requested review from
4e6,
Akirathan and
hubertp
as code owners
JaroslavTulach
changed the title
Semaphore and TruffleSafepoint
hubertp
approved these changes
Jan 7, 2026
Collaborator
hubertp
left a comment
hubertp
left a comment
There was a problem hiding this comment.
Tested on linux with guest parallelism > 1 and it seems to continue to work.
Haven't tested on Windows as I'm having problems building IDE distro locally on VM
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoPolyglotJava.java
Show resolved
Hide resolved
engine/runtime/src/main/java/org/enso/interpreter/runtime/EnsoPolyglotJava.java
Outdated
Show resolved
Hide resolved
Collaborator
|
Played a bit more on Windows and it didn't crash. Not that it is any kind of definitive test but that's always something. |
JaroslavTulach
added
the
CI: Ready to merge
|
Jaroslav Tulach reports a new STANDUP for yesterday (2026-01-08): Progress: .
|
1 task
hubertp
added a commit
that referenced
this pull request
Jan 27, 2026
…14687) * Revert "Avoid `Semaphore` and `TruffleSafepoint` (#14521)" This reverts commit d0f1851. * Revert "Avoid locks in `EnsoContext` (especially) on "fast path" (#14238)" This reverts commit 53c7cb1. * Revert "Replace synchronization blocks in polyglot Java initialization (#13907)" This reverts commit a8d646e. * bring back some useful changes * bring back changes modified by revert
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
developbranchTruffleSafepointthat were causing the troubles e409ed7Important Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Java,