This repository was archived by the owner on Dec 28, 2021. It is now read-only.
[WIP] Second checkpoint for alias analysis #359
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
farmaazon
approved these changes
Apr 15, 2020
Collaborator
farmaazon
left a comment
farmaazon
left a comment
There was a problem hiding this comment.
Well, I didn't get into detail, but I see here a nice bit of work. I leave only some minor comments.
| opt-level = 0 | ||
| lto = false | ||
| debug = false | ||
| debug = true |
Collaborator
There was a problem hiding this comment.
Why we set it to true? Have you checked why it was set to false?
Contributor
Author
There was a problem hiding this comment.
Ok, I need this to properly debug my test, it also provides line numbers in call stack when test is failing.
@wdanilo Can you comment why it was set to false? Is it still necessary?
| #[derive(Clone,Copy,Debug,Display,PartialEq)] | ||
| pub enum OccurrenceKind { Used, Introduced } | ||
|
|
||
| /// If the current context in the AST processor is a pattern context. |
Collaborator
There was a problem hiding this comment.
I'd like to have a reference to a document which describes what pattern context is.
Contributor
Author
There was a problem hiding this comment.
Will add TODO comment, to be fixed when #349 lands.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
Code should be functionally complete with the exception of macro support.
PR against the previous accepted checkpoint for #322.
Important Notes
Checklist
Please include the following checklist in your PR: