Add the ability to turn off huffman for given http2 protocol option. #42263
Conversation
Signed-off-by: Kevin Baichoo <[email protected]>
repokitteh-read-only
bot
added
api
deps
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
|
Assigning @RyanTheOptimist as a reviewer (legacy from #38270). Feel free to reassign if needed. |
|
Dependency change is the addition of a patch. Requires API review too /lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
/wait |
Signed-off-by: Kevin Baichoo <[email protected]>
repokitteh-read-only
bot
added
deps
repokitteh-read-only
bot
removed
the
deps
|
PTAL @markdroth |
| // Disables encoding the headers using huffman encoding. | ||
| // This can be useful in cases where the cpu spent encoding the headers isn't | ||
| // worth the network bandwidth saved e.g. for localhost. | ||
| bool disable_huffman_encoding = 18; |
There was a problem hiding this comment.
How about encoding this as google.protobuf.BoolValue enable_huffman_encoding, so that the data plane's default isn't necessarily baked into the API? It also avoids a double negative -- i.e., instead of if (!disable_huffman_encoding), we can say if (enable_huffman_encoding).
|
ping @KBaichoo it looks like this PR is waiting for you to address one comment |
|
yep will take a swing at this today -- have been busy with oncall 📟 |
Signed-off-by: Kevin Baichoo <[email protected]>
repokitteh-read-only
bot
added
the
deps
|
/lgtm api |
Signed-off-by: Kevin Baichoo <[email protected]>
|
/lgtm deps |
repokitteh-read-only
bot
removed
the
deps
|
@markdroth could you stamp again? |
|
/lgtm api |
7 participants
Commit Message: Add the ability to selectively remove huffman encoding headers as the sender for a given hop.
Additional Description: This is just #38270 without the wonked git history from being an old PR.
Risk Level: low (off by default)
Testing: Unit test, Running in Prod
Docs Changes: n/a
Release Notes: included
Platform Specific Features: n/a
Fixes: #38025