-
Notifications
You must be signed in to change notification settings - Fork 5.2k
Make max acceptable client hello size configurable via TlsInspector proto #42278
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
…roto Signed-off-by: Elisha Ziskind <[email protected]>
|
CC @envoyproxy/api-shepherds: Your approval is needed for changes made to |
botengyao
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just catches this from my another PR, thanks for adding this support!
/wait
api/envoy/extensions/filters/listener/tls_inspector/v3/tls_inspector.proto
Outdated
Show resolved
Hide resolved
Signed-off-by: Elisha Ziskind <[email protected]>
Signed-off-by: Elisha Ziskind <[email protected]>
Signed-off-by: Elisha Ziskind <[email protected]>
|
I am curious what's the motivation behind making this configurable. The current value is per the RFC specs. In what cases do we wanna change this? |
We want to be able to use a lower default value to limit abuse (eg. from DoS attacks) and only allow higher values (up to the RFC spec of 16K) when valid use-cases arise. |
Signed-off-by: Elisha Ziskind <[email protected]>
Make sense. Thanks for sharing. |
KBaichoo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thank you!
api/envoy/extensions/filters/listener/tls_inspector/v3/tls_inspector.proto
Show resolved
Hide resolved
Signed-off-by: Elisha Ziskind <[email protected]>
|
This still needs an API LGTM. |
This change allows configuring the maximum size of the ClientHello that the TLS inspector will process via the
TlsInspectorproto configuration. The default value is 16KiB. Theinitial_read_buffer_sizenow defaults to this configurable maximum size. No change to current behavior if the field is unset.Risk Level: low
Testing: unit tests