Open
Conversation
|
Hi @fergian94, welcome and thank you for your contribution. We will try to review your Pull Request as quickly as possible. In the meantime, please take a look at the contribution guidelines if you have not done so already. |
fergian94
requested a deployment
to
external-contributors
GitHub Actions
Waiting
phlax
reviewed
Feb 18, 2026
Member
phlax
left a comment
phlax
left a comment
There was a problem hiding this comment.
thanks for working on this @fergian94 - a couple of issues with backport
| RUNTIME_GUARD(envoy_restart_features_fix_dispatcher_approximate_now); | ||
| RUNTIME_GUARD(envoy_restart_features_skip_backing_cluster_check_for_sds); | ||
| RUNTIME_GUARD(envoy_restart_features_use_eds_cache_for_ads); | ||
| RUNTIME_GUARD(envoy_restart_features_validate_http3_pseudo_headers); |
|
|
||
| // TODO(yavlasov): Enabling by default will be hugely disruptive to existing traffic. | ||
| // Replace with a config option (default off) post CVE release. | ||
| FALSE_RUNTIME_GUARD(envoy_reloadable_features_reject_early_connect_data); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of the original #43277. Below text is copied from there:
Fixes #43116
Commit Message: healthcheck: defer health check until cluster finishes warming
Additional Description:
Active health checks started before the cluster finished initializing, causing failures when the cluster required SDS secrets for upstream connections. Health checks failed because the transport socket configuration was not ready, leading to intermittent failures at startup and when recreating the cluster to update the SDS reference, such as during certificate rotation..
See #43116 for full problem description.
This change defers the start of health checks until the cluster has finished warming, ensuring that all necessary configurations (including SDS secrets) are fetched before checks begin.
Risk Level: Low
Testing:
Added test to verify that health checks are deferred until the cluster warming state is cleared.
Docs Changes: N/A
Release Notes:
health_check: Fixed a race condition where active health checks could start before required upstream TLS SDS secrets were fetched, causing intermittent health check failures.
Platform Specific Features: N/A