Skip to content

Refactor: wrap long tautomer rule literal#3434

Merged
AlexeyGirin merged 2 commits intomasterfrom
copilot/refactor-long-lines-of-code
Jan 9, 2026
Merged

Refactor: wrap long tautomer rule literal#3434
AlexeyGirin merged 2 commits intomasterfrom
copilot/refactor-long-lines-of-code

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Jan 5, 2026

Remove-me-section

  • Notify reviewers about the pull request
  • Keep only necessary sections below for the review

Generic request

  • PR name follows the pattern #1234 – issue name
  • branch name does not contain '#'
  • base branch (master or release/xx) is correct
  • PR is linked with the issue
  • task status changed to "Code review"
  • code follows product standards
  • regression tests updated

For release/xx branch

  • backmerge to master (or newer release/xx) branch is created

Optional

  • unit-tests written
  • documentation updated

Backmerge request

  • PR name follows the pattern Backmerge: #1234 – issue name
  • PR is linked with the issue
  • base branch (master or release/xx) is correct
  • code contains only backmerge changes

Bump request

  • PR name follows the pattern Bump version to ...
  • add brackets [ ] for 'skip ci' and put it into the body
  • milestone is linked to PR
  • all tickets are closed inside the relevant milestone

Description

Long SMARTS rule literals in molecule_tautomer_enumerator.cpp exceeded line-length guidelines, hurting readability.

  • Formatting: Wrapped the longest tautomer SMARTS string into two adjacent literals to keep width within style limits while preserving behavior.

Example:

"[#1:0][N&v3,n,O,S:1][*:2]=,:[*:3][*:4]=,:[*:5][*:6]=,:[*:7][*:8]=,:[N&v3,n,O,S:9]>>"
"[N,n,O,S:1]=[A,a:2]-[A,a:3]=[A,a:4]-[A,a:5]=[A,a:6]-[A,a:7]=[A,a:8]-[N,n,O,S:9][#1:0]"
Original prompt

This section details on the original issue you should resolve

<issue_title>Refactor: Lines of code should not be too long</issue_title>
<issue_description>Problem:
Lines of code should not be too long

Why is this an issue?
Having to scroll horizontally makes it harder to get a quick overview and understanding of any piece of code.

Problem locations:
core/indigo-core/molecule/src/molecule_tautomer_enumerator.cpp:397</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Copilot AI changed the title [WIP] Refactor code to shorten long lines for better readability Refactor: wrap long tautomer rule literal Jan 5, 2026
Copilot AI requested a review from AlexeyGirin January 5, 2026 11:27
@AlexeyGirin AlexeyGirin marked this pull request as ready for review January 5, 2026 12:31
@AlexeyGirin AlexeyGirin requested review from AliaksandrDziarkach and removed request for AlexeyGirin January 5, 2026 12:32
@AlexeyGirin AlexeyGirin merged commit 550e8b8 into master Jan 9, 2026
65 of 66 checks passed
@AlexeyGirin AlexeyGirin deleted the copilot/refactor-long-lines-of-code branch January 9, 2026 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor: Lines of code should not be too long

3 participants