Move closest helper into core and rewire imports#9040
Open
Move closest helper into core and rewire imports#9040
Conversation
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Co-authored-by: AlexeyGirin <26869421+AlexeyGirin@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Update findClosestAtom function references and move file
Move closest helper into core and rewire imports
Jan 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
How the feature works? / How did you fix the issue?
findClosestAtom/closest utilities intoketcher-core, remove duplicate React copy, and update all call sites.closest.tsand its types intopackages/ketcher-core/src/application/editor/shared, exporting via core index (including defaultclosest).closest.jsand the React copy ofclosest.ts; React now consumes the core implementation and types.closest/ClosestItem*from core; adjusted context menu type comment.Example usage after change:
Check list
#1234 – issue nameOriginal prompt
findClosestAtomfunction frompackages\ketcher-core\src\application\editor\shared\closest.jsto usage offindClosestAtomfunction frompackages\ketcher-react\src\script\editor\shared\closest.ts#8939✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.