FIX Moment's Deprecation Warning also an infinity loop with the usage of @{push}.. in logArguments #58
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
follwing warning: - Deprecation warning: moment().subtract(period, number) is deprecated. Please use moment().subtract(number, period).
… of memory
This error happens when we want to get only the logs which was not
pushed to upstream using `@{push}..` with `logArguments` option,
sometimes the result using this command is empty causing an infinity
loop.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a deprecation warning as of v2.8.0 when using moment().subtract() shown in console when running
grunt changelog.Also if we want to changelog only commits which was not pushed to the origin I define the argument
@{push}..inlogArguments. But what happens if the branch is up-to-date with origin the log will be empty making an infinity loop and console running out of memory.