-
Notifications
You must be signed in to change notification settings - Fork 60
eth/69 support #256
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
shohamc1
wants to merge
13
commits into
master
Choose a base branch
from
shohamc1/eth69
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
eth/69 support #256
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
8c779fd
eth/69
shohamc1 1b76f1e
Earliest block
shohamc1 50aecd3
Rename MinBlockRequest, add MinimumBlockRequest
shohamc1 ae0a9ae
Add MinimumBlockAvailable
shohamc1 d1cb6ac
Add GET_RECEIPTS_69
shohamc1 2441584
Add Set prefix
shohamc1 b3b9eb1
Add Set prefix
shohamc1 2e694c3
Add SetPeerBlockRange
shohamc1 676ee33
Merge branch 'master' into shohamc1/eth69
shohamc1 1cb00ed
Merge branch 'master' into shohamc1/eth69
shohamc1 e33780e
Update num
shohamc1 7728ed4
Merge branch 'master' into shohamc1/eth69
shohamc1 6d31d26
change pos
shohamc1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@shohamc1 you should not be doing this - it is not backward compatible - just increment and add ETH69 after it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in general, never change the field tag number - https://stackoverflow.com/questions/65230623/safeness-of-changing-proto-field-number