Allow formatters to display stack traces on crash#541
Allow formatters to display stack traces on crash#541lrascao wants to merge 1 commit intoerlang-lager:masterfrom
Conversation
Only the last stack frame (ie. the place that cause the crash) is currently being shown in the message provided to the formatters, if you're interested in more information you'll need to dig into the crash.log for it. This is not ideal when using containerized environments with custom formatters, we want as much as data as possible to be available in the console backend.
|
IIRC we are only printing the last frame in the stack trace for safety reasons; that is, if you emit the entire stack trace you may be liable to OOM your VM if a gen_server with a giant 10MB state dies and gets printed over and over and over and over. So I am mildly concerned this patch opens a potentially unsafe log path. Trust me, though I get why you want more information from a container environment, but I think it should be carefully considered. |
|
That would indeed be bad, fortunately the crash report (to which this applies) does not carry the process state, that is left to the |
|
I would prefer to have a reasonable limit somewhere on the depth, yes, please. |
Only the last stack frame (ie. the place that cause the crash) is currently being
shown in the message provided to the formatters, if you're interested in more
information you'll need to dig into the crash.log for it.
This is not ideal when using containerized environments with custom formatters,
we want as much as data as possible to be available in the console backend.