Skip to content

fix: do not truncate MCP paths containing spaces #4409

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Diarica wants to merge 1 commit into from
+8 −7
Closed

fix: do not truncate MCP paths containing spaces #4409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions desktop/frontend/src/components/CapabilitiesPanel.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1244,13 +1244,12 @@ function EditServerForm({
const ready = isStdio ? command.trim() !== "" : url.trim() !== "";

const submit = () => {
const parts = command.trim().split(/\s+/).filter(Boolean);
const envText = env.trim();
onSave({
name: s.name,
transport,
command: isStdio ? (parts[0] ?? "") : "",
args: isStdio ? parts.slice(1) : [],
command: isStdio ? command.trim() : "",
args: [],
url: isStdio ? "" : url.trim(),
env: envText === "" ? null : parseEnvText(envText),
});
Expand Down Expand Up @@ -1625,7 +1624,6 @@ function AddServerForm({
const ready = name.trim() !== "" && (isStdio ? command.trim() !== "" : url.trim() !== "");

const submit = () => {
const parts = command.trim().split(/\s+/).filter(Boolean);
const envMap: Record<string, string> = {};
for (const line of env.split("\n")) {
const eq = line.indexOf("=");
Expand All @@ -1634,8 +1632,8 @@ function AddServerForm({
onAdd({
name: name.trim(),
transport,
command: isStdio ? (parts[0] ?? "") : "",
args: isStdio ? parts.slice(1) : [],
command: isStdio ? command.trim() : "",
args: [],
url: isStdio ? "" : url.trim(),
env: envMap,
});
Expand Down
5 changes: 4 additions & 1 deletion internal/config/mcpjson.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -158,7 +158,10 @@ func parseLegacyMCPSpec(raw string) (PluginEntry, bool) {
if !ok || len(parts) == 0 {
return PluginEntry{}, false
}
return PluginEntry{Name: name, Command: parts[0], Args: parts[1:]}, true
if shouldSplitPluginCommand(body, parts[0]) {
return PluginEntry{Name: name, Command: parts[0], Args: parts[1:]}, true
}
return PluginEntry{Name: name, Command: body}, true
}

// anonymousMCPName names a v0.x spec that carried no name= prefix (its tools
Expand Down