Skip to content

[codex] Fix short-window layout overflow #4482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jiaxindeyang-a11y wants to merge 1 commit into
base: main-v2
Choose a base branch
from
+26 −3
Open

[codex] Fix short-window layout overflow #4482

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion desktop/frontend/src/__tests__/typography-overflow-contract.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,10 @@ eq(
);

eq(finalDeclaration(".statusbar", "white-space"), "nowrap", "status bar keeps metrics on one row");
eq(finalDeclaration(".statusbar", "overflow"), "hidden", "status bar clips instead of overflowing");
eq(finalDeclaration(".statusbar", "overflow-x"), "auto", "status bar can scroll to reveal all metrics");
eq(finalDeclaration(".statusbar", "overflow-y"), "hidden", "status bar stays one-line vertically");
eq(finalDeclaration(".chat-pane", "overflow-y"), "auto", "chat pane scrolls when the window is too short");
eq(finalDeclaration(".sidebar", "overflow-y"), "auto", "sidebar scrolls when the window is too short");
clipsSingleLine(".statusbar__model");

for (const selector of [
Expand Down
24 changes: 22 additions & 2 deletions desktop/frontend/src/styles.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1606,7 +1606,13 @@ a[href] {
border-right: 1px solid var(--border-soft);
--wails-draggable: drag;
user-select: none;
overflow: hidden;
overflow-x: hidden;
overflow-y: auto;
scrollbar-width: none;
}

.sidebar::-webkit-scrollbar {
display: none;
}

.app--darwin .sidebar {
Expand Down Expand Up @@ -2084,6 +2090,8 @@ a[href] {
min-width: 0;
min-height: 0;
background: var(--chat-bg);
overflow-x: hidden;
overflow-y: auto;
}

/* ── top bar (drag region) ───────────────────────────────────────────────── */
Expand Down Expand Up @@ -5274,7 +5282,19 @@ a[href] {
CJK text breaks one character per line. The metric chips keep their width
(flex-shrink: 0) and only the model label ellipsizes to absorb the squeeze. */
white-space: nowrap;
overflow: hidden;
overflow-x: auto;
overflow-y: hidden;
scrollbar-width: thin;
}
.statusbar::-webkit-scrollbar {
height: 4px;
}
.statusbar::-webkit-scrollbar-thumb {
border-radius: 999px;
background: color-mix(in srgb, var(--fg-faint) 30%, transparent);
}
.statusbar::-webkit-scrollbar-track {
background: transparent;
}
.statusbar > * {
flex-shrink: 0;
Expand Down