Skip to content

Surface credential source diagnostics / 显示凭据来源诊断#4630

Merged
SivanCola merged 3 commits into
esengine:main-v2from
SivanCola:fix/credential-source-visibility
Jun 16, 2026
Merged

Surface credential source diagnostics / 显示凭据来源诊断#4630
SivanCola merged 3 commits into
esengine:main-v2from
SivanCola:fix/credential-source-visibility

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

  • Track the effective source for provider credentials, including environment variables, project .env, Reasonix credentials, home .env, and legacy credentials.
  • Surface credential source labels in desktop settings and provider auth errors.
  • Warn when saving a provider key would still be shadowed by an environment variable or project .env after restart.

Verification

  • go test ./...
  • go test . in the desktop module
  • npm --prefix desktop/frontend run typecheck

Related: #4608
Related: #4401

@SivanCola
SivanCola requested a review from esengine as a code owner June 16, 2026 16:25
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) provider Model providers & selection (internal/provider) labels Jun 16, 2026
@SivanCola

Copy link
Copy Markdown
Collaborator Author

@codex review

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 21e2171861

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/settings_app.go Outdated
Comment thread internal/config/credentials.go Outdated
Comment thread desktop/settings_app.go Outdated
@SivanCola
SivanCola merged commit 29ffd31 into esengine:main-v2 Jun 16, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent Core agent loop (internal/agent, internal/control) config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) provider Model providers & selection (internal/provider) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant