Skip to content

fix: align no-auth provider settings state#4698

Merged
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:codex/fix-no-auth-settings-pr4685
Jun 17, 2026
Merged

fix: align no-auth provider settings state#4698
SivanCola merged 1 commit into
esengine:main-v2from
SivanCola:codex/fix-no-auth-settings-pr4685

Conversation

@SivanCola

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #4685. This keeps Settings consistent with the new no-auth provider semantics by separating key presence from provider selectability.

  • Exposes requiresKey and configured on ProviderView so the frontend does not treat keySet as availability.
  • Lets no-auth custom providers appear in Settings model pickers and refresh model lists without api_key_env.
  • Avoids missing-key startup notices for loopback/private no-auth providers that keep a legacy api_key_env.
  • Updates browser mock behavior, labels, and regression tests.

Testing

  • git diff --check
  • go test ./internal/boot -count=1
  • cd desktop && go test . -count=1
  • cd desktop/frontend && corepack pnpm exec tsx src/__tests__/provider-model-refresh.test.ts

Notes

cd desktop/frontend && corepack pnpm exec tsc --noEmit -p tsconfig.test.json is currently blocked in this local worktree because generated Wails bindings are absent: ../../wailsjs/go/main/App cannot be resolved. The follow-on drift-check error comes from that missing generated module.

@SivanCola SivanCola requested a review from esengine as a code owner June 17, 2026 06:38
@github-actions github-actions Bot added v2 Go rewrite (1.x) — main-v2 branch, active development desktop Wails desktop app (desktop/**) config Configuration & setup (internal/config) labels Jun 17, 2026

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 393f48d67d

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread desktop/settings_app.go Outdated
@SivanCola SivanCola force-pushed the codex/fix-no-auth-settings-pr4685 branch from 393f48d to 089c7a9 Compare June 17, 2026 06:59
@SivanCola SivanCola enabled auto-merge June 17, 2026 07:00
@SivanCola SivanCola merged commit 934b1aa into esengine:main-v2 Jun 17, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

config Configuration & setup (internal/config) desktop Wails desktop app (desktop/**) v2 Go rewrite (1.x) — main-v2 branch, active development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant