update esp-hal-smartled (and esp-hal-buzzer) for esp-hal 1.0.0-rc.1#53
update esp-hal-smartled (and esp-hal-buzzer) for esp-hal 1.0.0-rc.1#53bugadani merged 7 commits intoesp-rs:mainfrom badamson:updates-for-esp-hal-1.0.0-rc.1
esp-hal-smartled (and esp-hal-buzzer) for esp-hal 1.0.0-rc.1#53Conversation
badamson
requested review from
AnthonyGrondin,
jamessizeland,
robamu and
taorye
as code owners
|
We might just have a easier time feature gating it. |
|
thank you @AnthonyGrondin.
Went with gpio4 for now.
Ha, I did that initially but didn't want to complicate the example. Failing 4, sounds good. |
This replaces esp-hal-embassy with esp-rtos and updates deps. It makes backwards-incompatible changes for updates to the esp-hal rmt api: - https://docs.rs/esp-hal/1.0.0-rc.0/esp_hal/rmt/index.html - https://docs.rs/esp-hal/1.0.0-rc.1/esp_hal/rmt/index.html
|
I'll test this on my ESP32-C3 dev board as well. ran out of ESP32-C6 I can easily access unfortunately... |
|
This should need a Changelog entry too. |
hicklin
left a comment
hicklin
left a comment
There was a problem hiding this comment.
I did not realise you were working on this and submitted my own PR. I closed my PR since your changes include fixes to the buzzer crate and cascade the use of the new PulseCode type which I left as a todo.
I have one comment about bumping the version. If we do so, we should probably also update the CHANGELOG.md. You can copy what I have in my closed PR and add to it as required.
esp-hal-smartled/src/lib.rs
Outdated
| macro_rules! smart_led_buffer { | ||
| ( $num_leds: expr ) => { | ||
| [0u32; $crate::buffer_size($num_leds)] | ||
| [::esp_hal::rmt::PulseCode::default(); $crate::buffer_size($num_leds)] |
There was a problem hiding this comment.
Use PulseCode::end_marker() otherwise this macro won't work in const contexts.
…-smartled` to `0.17.0` - `cargo-edit`, `cargo set-version --workspace --bump minor`
6 participants
This pr updates
esp-hal-smartledandesp-hal-buzzerforesp-hal1.0.0-rc.1.It replaces
esp-hal-embassywithesp-rtos(w embassy feature) and updates deps. It makes backwards-incompatible changes for updates to theesp-halrmt api:It also removes theesp_bootloader_esp_idfdependency. The examples callesp_bootloader_esp_idf::esp_app_desc!(), but my understanding is that this is handled by flash tools and shouldn't be necessary.The buzzer example's gpio pin was changed from 6 to 4 (edit: was 0) to fix build issues with
h2.This will still fail the docs build, pending a workaround or release of c6 that includes this fix:
https://github.com/esp-rs/esp-pacs/pull/381/files#diff-7cbde23f76faa89e81718f84999835338714b12a5cbccef5c5a1663cd1783fa6R6
Resolves #51.