Skip to content

Fix how rustup is verified/installed#34

Merged
bugadani merged 1 commit intoesp-rs:mainfrom
SergioGasquez:fix/rustup-installation
Feb 3, 2025
Merged

Fix how rustup is verified/installed#34
bugadani merged 1 commit intoesp-rs:mainfrom
SergioGasquez:fix/rustup-installation

Conversation

@SergioGasquez
Copy link
Member

@SergioGasquez SergioGasquez commented Feb 3, 2025

https://github.com/esp-rs/esp-hal/actions/runs/13109391906/job/36569814277?pr=3072 occurred because Rust is not present, its installed by the action but the path is not updated, hence the next steps couldn't find the binary

This didnt occurred in the CI checks of the action as the gh-hosted-runners already have rust installed

esp-hal test: https://github.com/esp-rs/esp-hal/actions/runs/13110802777

@bugadani bugadani merged commit b989c80 into esp-rs:main Feb 3, 2025
4 checks passed
@SergioGasquez SergioGasquez deleted the fix/rustup-installation branch February 3, 2025 10:04
@SergioGasquez
Copy link
Member Author

I probably should have looked at dtolnay action, it does it slightly different: https://github.com/dtolnay/rust-toolchain/blob/v1/action.yml#L69-L76, don't think its worth the update but if in the future we want to change it, we could copy it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants