Repository navigation
Conversation
2 of 19 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
bdraco
marked this pull request as ready for review
September 23, 2026 15:34
|
|
esphbot
approved these changes
Sep 23, 2026
esphbot
left a comment
There was a problem hiding this comment.
Tip
No blocking issues found — ready to merge.
PR Review — Announce the MCP server to Home Assistant from dev and betaMerge-ready. The per-channel override approach is correct, and I found no new issues. What works well:
Follow-up, not a blocker:
Checklist
Automated review by Kōan (Claude) |
esphbot
approved these changes
Oct 6, 2026
esphbot
left a comment
There was a problem hiding this comment.
Tip
No blocking issues found — ready to merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds
mcpto the supervisordiscovery:list so the Device Builder can announce its MCP server to Home Assistant'smcpintegration (one-click confirm). The supervisor rejects discovery for services not listed here.template/addon_config.yaml. Stable is unchanged until 2026.10 ships, then movemcpintobaseand drop the overrides.Related: esphome/device-builder#2733 (server), discovery script in esphome, home-assistant/core#180378 (HA side).