fix: indexing in DNS server IP address retrieval #17751 (IDFGH-16654) #17752
+1
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix #17751 :
Bug in DNS server: Incorrect array indexing when checking IP address (IDFGH-16653)
Answers checklist.
esp-idf/examples/protocols/http_server/captive_portal/components/dns_server/dns_server.c
Line 161 in ab14938
The DNS server does not use the correct entry index when checking the IP address.
instead of
which causes it to always check entry 0 regardless of which entry matched in the loop.
This bug prevents proper DNS resolution when multiple entries are configured and the matching entry is not at index 0.
Checklist
Before submitting a Pull Request, please ensure the following: