Skip to content

Conversation

@Hahihula
Copy link
Collaborator

This shoud cause futere msi windows installers of the eim to actually add the eim to the system path automatically.

@gemini-code-assist
Copy link

Summary of Changes

Hello @Hahihula, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant improvement to the Windows installer for the 'eim' application. By integrating a custom WiX template, the installer will now automatically append the application's installation path to the system's environment variables. This change simplifies the post-installation setup for users, enabling them to execute the application directly from any command-line interface without manual configuration.

Highlights

  • Custom WiX Template Integration: The Tauri configuration has been updated to utilize a custom WiX template for generating Windows installers, allowing for more granular control over the installation process.
  • Automatic System PATH Update: A new WiX XML file has been introduced to automatically add the application's installation directory to the system's PATH environment variable during the MSI installation, making the application easily accessible from the command line.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to add the application's installation directory to the system PATH on Windows. The change in tauri.conf.json is correct for enabling a custom WiX template. However, the provided WiX template in wix/main.wxs is incomplete; it's a fragment instead of a full template file, which will cause the installer build to fail. My review includes a critical comment explaining how to create a proper WiX template based on Tauri's default and correctly include the PATH modification logic.

Comment on lines 1 to 15
<?xml version="1.0" encoding="utf-8"?>
<Wix xmlns="http://schemas.microsoft.com/wix/2006/wi">
<Fragment>
<Component Id="Path" Guid="A6734AA2-8C86-49D5-8501-2DD147D7C816" Directory="INSTALLDIR">
<Environment
Id="PATH"
Name="PATH"
Value="[INSTALLDIR]"
Permanent="no"
Part="last"
Action="set"
System="yes" />
</Component>
</Fragment>
</Wix>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This file is a WiX fragment, but Tauri's wix.template option expects a full WiX source file that defines a <Product>. As a fragment, this file is incomplete and will cause the MSI build to fail.

You should use the default Tauri WiX template as a starting point. You can find it in the Tauri repository. After obtaining the full template, you need to add your Component for modifying the PATH and then reference it from a Feature.

  1. Place the following Component inside the INSTALLDIR Directory element in your template:

    <Component Id="Path" Guid="A6734AA2-8C86-49D5-8501-2DD147D7C816">
      <Environment Id="Path" Name="PATH" Value="[INSTALLDIR]" Permanent="no" Part="last" Action="set" System="yes" />
    </Component>
  2. Add a reference to this component inside the main Feature element:

    <Feature Id="MainFeature" Title="Main Feature" Level="1">
      {{> main.wxs.components}}
      <ComponentRef Id="Path" />
    </Feature>

This will correctly integrate your PATH modification into the installer.

@Hahihula Hahihula force-pushed the msi-add-to-path branch 7 times, most recently from 00add7c to 8f4b48d Compare November 10, 2025 13:46
@Hahihula Hahihula changed the title modified wix so msi will be added to the system path WIP: modified wix so msi will be added to the system path Nov 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants