Draft
Conversation
Provide an alternative implementation of SingleReaction, ReactionAlgorithm and ConstantpHEnsemble in pure Python for rapid prototyping of new Monte Carlo methods. Co-authored-by: Pablo Miguel Blanco Andrés <blancoapa@natur.cuni.cz>
| If the exclusion radius of one particle type is not defined, the value of the parameter provided in ``exclusion_range`` is used by default. | ||
| If the value in ``exclusion_radius_per_type`` is equal to 0, then the exclusion range of that particle type with any other particle is 0. | ||
| This integration instabilities can be avoided by defining a distance around | ||
| the particles which already exist in the system where new particles will not |
Member
There was a problem hiding this comment.
Could you improve this sentence here please:
"... where new particles will not be inserted and old particles will not be removed (to maintain detailed balance)."
| acceptance_rate = reaction.get_acceptance_rate() | ||
| print(f"acceptance rate = {100. * acceptance_rate:.0f}%") | ||
| print(f"alpha = {alpha_avg:.2f} +/- {alpha_err:.2f}") | ||
| print(f"runtime = {tock - tick:.2f}s") |
Member
There was a problem hiding this comment.
What do you think about splitting this file into yet another python module to separate the example and the mc functionality?
Did you already consider using just in time compilation in some of the functions to cut down the factor 4 difference?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #4617