Skip to content

Add option to skip ghost force reduction#4777

Draft
capomav wants to merge 2 commits intoespressomd:pythonfrom
capomav:ghost_force_reduction
Draft

Add option to skip ghost force reduction#4777
capomav wants to merge 2 commits intoespressomd:pythonfrom
capomav:ghost_force_reduction

Conversation

@capomav
Copy link
Copy Markdown
Contributor

@capomav capomav commented Aug 22, 2023

Fixes #4556

@RudolfWeeber
Copy link
Copy Markdown
Contributor

Lgtm so far. Next step are

  • skip setting up the collect_ghost_forces_comm in the constructor of RegularDecomposiotion (srccore/cell_systems/RegularDecomposition.cpp) if the flag is ture.
  • Modify the testsuite/python/lj.py so that it runs one test without skipping the ghost force reduction and another with skipping it. That second test will fail.
  • check RegularDecomposition::init_cell_neighbors() to make sure, that the neighborship of ghost cells is set up correctly
  • Modify the short range loop to also run on pairs of ghost cells and their red_neighbors.

@capomav capomav force-pushed the ghost_force_reduction branch from c2c37d6 to 6154c61 Compare September 4, 2023 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Eliminate the need for a ghost force reduction

2 participants