Skip to content

Remove the fallback code, where Kokkos versions are available#5276

Draft
RudolfWeeber wants to merge 7 commits intoespressomd:pythonfrom
RudolfWeeber:shared_mem_everywhere
Draft

Remove the fallback code, where Kokkos versions are available#5276
RudolfWeeber wants to merge 7 commits intoespressomd:pythonfrom
RudolfWeeber:shared_mem_everywhere

Conversation

@RudolfWeeber
Copy link
Copy Markdown
Contributor

find src/core -name '.hpp' -o -name '.cpp' -o -name '*.impl.hpp' |
xargs grep -l ESPRESSO_SHARED_MEMORY_PARALLELISM |
xargs -I{} unifdef -DESPRESSO_SHARED_MEMORY_PARALLELISM -t {} -o /dev/null

…M disabled

find src/core -name '*.hpp' -o -name '*.cpp' -o -name '*.impl.hpp' | \
    xargs grep -l ESPRESSO_SHARED_MEMORY_PARALLELISM | \
    xargs -I{} unifdef -DESPRESSO_SHARED_MEMORY_PARALLELISM -t {} -o /dev/null
@RudolfWeeber RudolfWeeber force-pushed the shared_mem_everywhere branch from 56920ec to 5b0dbc9 Compare March 22, 2026 11:55
@jngrad jngrad force-pushed the shared_mem_everywhere branch from a8ff3cb to 941fb0d Compare April 1, 2026 22:39
@jngrad
Copy link
Copy Markdown
Member

jngrad commented Apr 1, 2026

Blocked by espressomd/docker#224

Now that all CI jobs use shared memory, FPE tests can run on the parallel code, and divisions by zero are detected.

@jngrad
Copy link
Copy Markdown
Member

jngrad commented Apr 1, 2026

A floating-point exception is triggered in cufftPlan3d. Using ./pypresso --gdb ../testsuite/python/coulomb_tuning.py CoulombCloudWallTune.test_p3m_gpu with a hardcoded mesh=156 reproduces the issue on lama. I'm not exactly sure why CUDA is affected by FPE traps, this is supposed to be a CPU feature.

ScaFaCoS dipoles are also affected, usually in the tuning function. GDB has trouble extracting the source code from my ScaFaCoS library built in Debug mode...

The Verlet test triggers a FPE because we purposefully place 1000 particles at the box origin to check the Verlet list backup algorithm when the neighbor list is too small. This test clearly needs to be skipped when FPE is enabled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants