messagegui: Fix bugs related to empty titles and bodies. #3972
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes espruino#3969. Notification events can now have title or body as empty strings or `undefined` without errors. Tested from console using the below notification messages sent from console. Prior to this commit, all but the two marked test messages created errors. GB({"t":"notify", "id":987123, "title":"Title"}) GB({"t":"notify", "id":987124, "title":"Title", "body":""}) GB({"t":"notify", "id":987125, "body":"Body"}) GB({"t":"notify", "id":987126, "title":"", "body":"Body"}) // worked before this commit GB({"t":"notify", "id":987127, "title":""}) GB({"t":"notify", "id":987128, "body":""}) GB({"t":"notify", "id":987129}) // does nothing
bobrippling
reviewed
Aug 22, 2025
| body = title; | ||
| title = undefined; | ||
| title = ""; | ||
| } | ||
| if (g.setFont(srcFont).stringWidth(src) > g.getWidth()-52) | ||
| srcFont = "4x6"; |
There was a problem hiding this comment.
Thanks, looks good! To avoid a future regression, perhaps we comment about the relation here?
Suggested change
| srcFont = "4x6"; | |
| srcFont = "4x6"; | |
| // one of `title` or `body` must be truthy at this point (#3969) |
There was a problem hiding this comment.
I just added another commit with a comment. I wrote it differently, because the total set of issues ended up being not just about truthiness but variables being undefined yet referenced later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3969. Notification events can now have title or body as empty strings or
undefinedwithout errors. Tested using the below notification messages sent from console. Prior to this commit, all but the two marked test messages created errors. Also tested with actual task notifications from Android.