Skip to content

Conversation

LucienStorm
Copy link

Hopefully I've cleared all of the issues.

LucienStorm and others added 4 commits October 9, 2025 22:39
A watchface inspired by some popular cartoon characters.
to follow the usual style for apps in the espruino/BangleApps repo.
... to follow the standard for the espruino/BangleApps repo.
@thyttan
Copy link
Collaborator

thyttan commented Oct 14, 2025

@bobrippling could you take a look at the checker output? Something is going wrong:

TypeError: app.tags.split is not a function
    at /home/runner/work/BangleApps/BangleApps/bin/sanitycheck.js:209:37
    at Array.forEach (<anonymous>)
    at Object.<anonymous> (/home/runner/work/BangleApps/BangleApps/bin/sanitycheck.js:197:6)
    at Module._compile (node:internal/modules/cjs/loader:1364:14)
    at Module._extensions..js (node:internal/modules/cjs/loader:1422:10)
    at Module.load (node:internal/modules/cjs/loader:1203:32)
    at Module._load (node:internal/modules/cjs/loader:1019:12)
    at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:128:12)
    at node:internal/main/run_main_module:28:49

@RKBoss6
Copy link
Contributor

RKBoss6 commented Oct 14, 2025

Ah, I think in metadata.json tags: is not an array, just a string, eg: "clock". The checker doesn't know how to split the array, since it should be a string. Hope that helps!

removed clock array brackets
Copy link
Author

@LucienStorm LucienStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metadata file updated

Copy link
Author

@LucienStorm LucienStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Settings, metadata, and app-icon all updated

@bobrippling
Copy link
Collaborator

Yeah that was it - LGTM but will let you finish your review if you like @thyttan

@thyttan
Copy link
Collaborator

thyttan commented Oct 18, 2025

You're close now 😉 : https://github.com/espruino/BangleApps/actions/runs/18608508358/job/53074607304#step:5:8

So add icon for the app loader and launchers and we're probably good to go.

Tried different settings on the image compression
Copy link
Author

@LucienStorm LucienStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tried different settings on the app icon image compression. Hopefully this passes

@RKBoss6
Copy link
Contributor

RKBoss6 commented Oct 18, 2025

You'll also need an app.png file with the icon of the app, not ported to JS. The js icon is for the watch to display it in launchers, and the .png icon is for the app loader. So adding a app.png file with the png version of the app icon in app-icon.js will make this good to go!

@LucienStorm
Copy link
Author

app

@LucienStorm
Copy link
Author

I'm going to cancel this pull request and start another with that file. I'm not sure if there's any other way to add a file to a current commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants