lease: Client should stop sending keepAlive requests after recv channel closed #21126
Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: zhijun42 The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
|
Hi @zhijun42. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
zhijun42
force-pushed
the
require-leader-exits
branch
from
7b563d0 to
e36b5c3
Compare
zhijun42
force-pushed
the
require-leader-exits
branch
from
e36b5c3 to
67a9324
Compare
|
|
||
| // TestLeaseWithRequireLeader checks keep-alive channel close when no leader, | ||
| // and verifies lease expiration behavior after leader is restored. | ||
| func TestLeaseWithRequireLeader(t *testing.T) { |
There was a problem hiding this comment.
Please don't move the test as it makes diff unreadable and breaks history.
There was a problem hiding this comment.
Okay, I was trying to make diff more readable but looks like I did poorly. Rearranged the code.
Signed-off-by: Zhijun <[email protected]>
zhijun42
force-pushed
the
require-leader-exits
branch
from
67a9324 to
b55a774
Compare
| } | ||
|
|
||
| // TestLeaseWithRequireLeader checks keep-alive channel close when no leader. | ||
| // TestLeaseWithRequireLeader checks keep-alive channel close when no leader, |
There was a problem hiding this comment.
Improve test name by using the comment. TestLeaseKeepAliveAndExpirationWithNoLeader
Signed-off-by: Zhijun <[email protected]>
3 participants
If a lease client sets this
withRequireLeaderand closes its receive channel due to no leader, it should also stop sending more keepAlive requests to the server (it wouldn't have a channel to receive response anyway).I extended the existing test function
TestLeaseWithRequireLeaderto verify this update and it now has two test cases:Also fixed the bug of
newIdx. Surprisingly this wasn't caught for the past 9-ish years.