Time all stages of robustness tests using t.Run #21154
Conversation
serathius
force-pushed
the
robustness-timing
branch
from
e7e45a1 to
c384dc1
Compare
Thanks to junit reading subtest this should allow to see timings in Testgrid. Signed-off-by: Marek Siarkowicz <[email protected]>
serathius
force-pushed
the
robustness-timing
branch
from
c384dc1 to
9181286
Compare
|
@serathius: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted filessee 21 files with indirect coverage changes @@ Coverage Diff @@
## main #21154 +/- ##
==========================================
+ Coverage 68.35% 68.39% +0.04%
==========================================
Files 429 429
Lines 35267 35267
==========================================
+ Hits 24107 24122 +15
+ Misses 9766 9749 -17
- Partials 1394 1396 +2 Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
| // As for the report, the original report is used so the consumer doesn't need to track what patching was done or not. | ||
| if len(persistedRequests) != 0 { | ||
| linearizableOperations = patchLinearizableOperations(linearizableOperations, reports, persistedRequests) | ||
| t.Run("Patch", func(tl TimerLogger) { |
There was a problem hiding this comment.
| t.Run("Patch", func(tl TimerLogger) { | |
| t.Run("Patch", func(t TimerLogger) { |
| if err != nil { | ||
| lg.Error("Watch validation failed", zap.Error(err)) | ||
| } | ||
| lg.Info("Watch validation success") |
There was a problem hiding this comment.
| lg.Info("Watch validation success") | |
| } else { | |
| lg.Info("Watch validation success") | |
| } |
| if err != nil { | ||
| lg.Error("Serializable validation failed") | ||
| } | ||
| lg.Info("Serializable validation success") |
There was a problem hiding this comment.
| lg.Info("Serializable validation success") | |
| } else { | |
| lg.Info("Serializable validation success") | |
| } |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: henrybear327, serathius The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
3 participants
Thanks to junit reading subtest this should allow to see timings in Testgrid.
/cc @henrybear327