Skip to content

Conversation

@aaomidi
Copy link

@aaomidi aaomidi commented Jan 18, 2026

Summary

Add CAReloader that polls CA files and updates the certificate pool when changes are detected (using SHA256 hashing). This enables zero-downtime CA rotation for mTLS clusters.

Changes

  • Add CAReloader struct with Start()/Stop() lifecycle management
  • Use sync.RWMutex for thread-safe pool access
  • Use sync.WaitGroup for graceful shutdown (follows etcd patterns)
  • Graceful fallback: invalid CA files keep using cached pool
  • Add Prometheus metrics for reload operations (etcd_tlsutil_ca_reload_*)

Background

This PR is a split of #21074 into smaller, reviewable pieces as requested by maintainers.

Stacking

This PR is part of a stacked PR series for CA hot-reload support (issue #11555):

  1. This PR - tlsutil: add CAReloader
  2. transport,embed: integrate CA hot-reload support #21157 - transport,embed: integrate CA hot-reload support
  3. tests: add CA rotation integration test and manual testing tools #21158 - tests: add CA rotation integration test

Part 1 of 3 for CA hot-reload support.
Replaces #21074 (split into smaller PRs)
Partially fixes #11555

Signed-off-by: Amir Omidi amir@aaomidi.com

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: aaomidi
Once this PR has been reviewed and has the lgtm label, please assign serathius for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link

Hi @aaomidi. Thanks for your PR.

I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Add CAReloader that polls CA files and updates the certificate pool
when changes are detected (using SHA256 hashing). This enables
zero-downtime CA rotation for mTLS clusters.

Key changes:
- Add CAReloader struct with Start/Stop lifecycle management
- Use sync.RWMutex for thread-safe pool access
- Graceful fallback: invalid CA files keep using cached pool
- Add Prometheus metrics for reload operations

Part 1 of CA hot-reload support (issue etcd-io#11555).

Signed-off-by: Amir Omidi <amir@aaomidi.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

ETCD doesn't automatically load changes to ca bundles for peer-trusted-ca-file or trusted-ca-file

2 participants