Conversation
Test verifies that IsOnCurve rejects points with coordinates >= P. Without the fix in the next commit, this test fails because coordinates equivalent mod P (e.g. Gx+P) are incorrectly accepted as valid. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
…ation) Add item count validation before full RLP message decoding in both eth and snap protocol handlers. This prevents memory amplification attacks where compact RLP-encoded items expand into large in-memory objects. The check uses rlp.CountValues on the raw payload to count items without allocating memory for decoded objects. Messages exceeding the expected limits are rejected before any decoding occurs. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com>
Signed-off-by: Diego López León <dieguitoll@gmail.com> # Conflicts: # params/version.go
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Merge Hermes (v1.12.22) release branch into master.
Release: https://github.com/etclabscore/core-geth/releases/tag/v1.12.22