This repository was archived by the owner on Apr 24, 2022. It is now read-only.
update hunter link for issue #2290#2291
Open
arthw wants to merge 1 commit intoethereum-mining:masterfrom
Open
Conversation
This PR is used to fix the issue error: downloading 'https://dl.bintray.com/boostorg/release/1.66.0/source/boost_1_66_0.7z' failed ethereum-mining#2290 The original hunter is ruslo/hunter is not maintained. The link of boost included in it is unavailable now. So, update the cpp_pm/hunter to fix the boost link issue.
gruuk
reviewed
May 13, 2021
| URL "https://github.com/ruslo/hunter/archive/v0.23.112.tar.gz" | ||
| SHA1 "4b894e1d5d203f0cc9a77431dbb1b486ab6f4430" | ||
| LOCAL | ||
| URL "https://github.com/cpp-pm/hunter/archive/v0.23.300.tar.gz" |
There was a problem hiding this comment.
It is actually enough and easier to just replace the "ruslo" with "cpp-pm" and keep the same package version and SHA1. This saves troubles with required CMake version upgrade and adaptations to newer Boost version.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR is used to fix the issue error: downloading 'https://dl.bintray.com/boostorg/release/1.66.0/source/boost_1_66_0.7z' failed #2290
The original hunter is ruslo/hunter is not maintained. The link of boost included in it is unavailable now.
So, update the cpp_pm/hunter to fix the boost link issue.