Skip to content

fix: regenerate BalanceChangeReason stringer#456

Open
spacexbt wants to merge 1 commit intoethereum-optimism:optimismfrom
spacexbt:fix/balance-change-stringer
Open

fix: regenerate BalanceChangeReason stringer#456
spacexbt wants to merge 1 commit intoethereum-optimism:optimismfrom
spacexbt:fix/balance-change-stringer

Conversation

@spacexbt
Copy link
Copy Markdown

Fixes #408

This PR regenerates the stringer code for the BalanceChangeReason type to properly support all balance change reasons, including the Optimism-specific ones.

Changes:

  1. Added proper go:generate directive in balance.go
  2. Regenerated balance_change_string.go with all current balance change reasons

This fixes the issue where BalanceMint was showing up as "BalanceChangeReason(200)" instead of "BalanceMint".

Testing:

  • Ran go:generate for BalanceChangeReason
  • Verified all balance change reasons are properly stringified
  • No breaking changes to existing functionality

Resolves the issue where the stringer wasn't updated after adding new balance change reasons.

@spacexbt spacexbt requested a review from a team as a code owner December 30, 2024 00:15
@spacexbt spacexbt requested a review from geoknee December 30, 2024 00:15
ajsutton pushed a commit to ajsutton/todo-ui that referenced this pull request Apr 4, 2026
…kdown

- Standup items now identified by PR/issue ref link + description text
  (e.g. "ethereum-optimism/op-geth#456 Fix gas estimation") instead of
  TODO-N IDs. HTML uses descWithRefHtml() to extract the leading markdown
  link from the description field; Slack copy uses descWithRefSlack() for
  <url|ref> format.

- Claude tab now shows a live <pre> preview while streaming, then switches
  to rendered HTML (via renderSimpleMarkdown/inlineMarkdown) when done.
  The Copy button always copies the raw markdown text so it pastes cleanly
  into Slack or other tools.

https://claude.ai/code/session_01X1kmiHLtsnuS4VfNsTVbG5
ajsutton pushed a commit to ajsutton/todo-ui that referenced this pull request Apr 4, 2026
…kdown

- Standup items now identified by PR/issue ref link + description text
  (e.g. "ethereum-optimism/op-geth#456 Fix gas estimation") instead of
  TODO-N IDs. HTML uses descWithRefHtml() to extract the leading markdown
  link from the description field; Slack copy uses descWithRefSlack() for
  <url|ref> format.

- Claude tab now shows a live <pre> preview while streaming, then switches
  to rendered HTML (via renderSimpleMarkdown/inlineMarkdown) when done.
  The Copy button always copies the raw markdown text so it pastes cleanly
  into Slack or other tools.

https://claude.ai/code/session_01X1kmiHLtsnuS4VfNsTVbG5
ajsutton pushed a commit to ajsutton/todo-ui that referenced this pull request Apr 4, 2026
…kdown

- Standup items now identified by PR/issue ref link + description text
  (e.g. "ethereum-optimism/op-geth#456 Fix gas estimation") instead of
  TODO-N IDs. HTML uses descWithRefHtml() to extract the leading markdown
  link from the description field; Slack copy uses descWithRefSlack() for
  <url|ref> format.

- Claude tab now shows a live <pre> preview while streaming, then switches
  to rendered HTML (via renderSimpleMarkdown/inlineMarkdown) when done.
  The Copy button always copies the raw markdown text so it pastes cleanly
  into Slack or other tools.

https://claude.ai/code/session_01X1kmiHLtsnuS4VfNsTVbG5
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incompleteness balanche change reason

1 participant