eth/tracers: add txHash to pre-bedrock historical trace results#576
Open
bbaktaeho wants to merge 1 commit intoethereum-optimism:optimismfrom
Open
eth/tracers: add txHash to pre-bedrock historical trace results#576bbaktaeho wants to merge 1 commit intoethereum-optimism:optimismfrom
bbaktaeho wants to merge 1 commit intoethereum-optimism:optimismfrom
Conversation
teddyknox
approved these changes
Apr 14, 2025
|
/ci authorize 0d73c8f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When querying debug_traceBlockXXX RPC methods on pre-Bedrock blocks, the txHash field is missing in the results.
Below is an example from block number 4, using
debug_traceBlockByNumberwith thecallTracer:{ "jsonrpc": "2.0", "id": 1, "result": [ { "txHash": "0x0000000000000000000000000000000000000000000000000000000000000000", "result": { "from": "0x7107142636c85c549690b1aca12bdb8052d26ae6", "gas": "0x2130", "gasUsed": "0x2130", "input": "0xbede39b500000000000000000000000000000000000000000000000000000029a05f69e1", "output": "0x", "time": "1.804646ms", "to": "0x420000000000000000000000000000000000000f", "type": "CALL", "value": "0x0" } } ] }As you can see, txHash is set to a zero hash.
This PR initializes the txHash field using the corresponding transaction from the block that was traced.
real result:
{ "jsonrpc": "2.0", "id": 1, "result": [ { "txHash": "0xc1d20abbdd2a63df8dcd8eba2bdcf850d067109dd626964a9987747a154b8fdb", "result": { "from": "0x7107142636c85c549690b1aca12bdb8052d26ae6", "gas": "0x2130", "gasUsed": "0x2130", "input": "0xbede39b500000000000000000000000000000000000000000000000000000029a05f69e1", "output": "0x", "time": "34.258333ms", "to": "0x420000000000000000000000000000000000000f", "type": "CALL", "value": "0x0" } } ] }Tests
Additional context
Metadata