Skip to content

Update EIP-712: typo fix #9699

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 27, 2025
Merged

Update EIP-712: typo fix #9699

merged 2 commits into from
May 27, 2025

Conversation

@wmjae
Copy link
Contributor

@wmjae wmjae commented Apr 28, 2025

No description provided.

@wmjae wmjae requested a review from eth-bot as a code owner April 28, 2025 01:52
@github-actions github-actions bot added c-update Modifies an existing proposal s-final This EIP is Final t-core t-interface labels Apr 28, 2025
@eth-bot
Copy link
Collaborator

eth-bot commented Apr 28, 2025 •
edited
Loading

File EIPS/eip-712.md

Requires 1 more reviewers from @dekz, @LogvinovLeon, @recmo
Requires 1 more reviewers from @lightclient, @SamWilsn, @xinbenlv

File EIPS/eip-7691.md

Requires 1 more reviewers from @adietrichs, @nerolation, @parithosh, @samcm, @Savid

@eth-bot eth-bot added the e-consensus Waiting on editor consensus label Apr 28, 2025
@eth-bot eth-bot changed the title Update EIP-7691: typo fix Update EIP-712: typo fix Apr 28, 2025
@github-actions github-actions bot added the w-ci Waiting on CI to pass label Apr 28, 2025
g11tech
g11tech previously approved these changes May 6, 2025
View reviewed changes
Copy link
Contributor

@g11tech g11tech left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving, although this will require approval from authors of both EIPs as well, so shuld be a better way to do a separate PRs for each of them to keep dependancy limited

@Savid
Copy link
Member

Savid commented May 6, 2025

airdrop farmer

#9567
#9541
OffchainLabs/cargo-stylus#158
0xPolygon/cdk-validium-node#173
across-protocol/relayer#2171

This was referenced May 20, 2025
Closed
Closed
@github-actions github-actions bot removed the t-core label May 27, 2025
@SamWilsn SamWilsn merged commit 8ef21eb into ethereum:master May 27, 2025
7 of 10 checks passed
@github-actions
Copy link

The commit a36cec5 (as a parent of 4a1c980) contains errors.
Please inspect the Run Summary for details.

nerolation pushed a commit to nerolation/EIPs that referenced this pull request Aug 11, 2025
@wmjae @SamWilsn @nerolation
Update EIP-712: typo fix (ethereum#9699)
f4d6848 
* Update EIP-7691: typo fix

* Update eip-7691.md

---------

Co-authored-by: Sam Wilson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@g11tech g11tech g11tech left review comments

@eth-bot eth-bot Awaiting requested review from eth-bot eth-bot is a code owner

Assignees

No one assigned

Labels

c-update Modifies an existing proposal e-consensus Waiting on editor consensus s-final This EIP is Final t-interface w-ci Waiting on CI to pass

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wmjae @eth-bot @Savid @g11tech @SamWilsn