BUGFIX: Resolves a visual layout issue where a significant whitespace gap appeared below the site footer. #16692
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change FixedDot position to fixed on the right, to fix the extra padding that was created from the feedback widget.
flatsponge
requested review from
corwintines,
minimalsm,
pettinarip and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
corwintines
approved these changes
Nov 27, 2025
Member
corwintines
left a comment
corwintines
left a comment
There was a problem hiding this comment.
Thanks @flatsponge
I pushed up a bit to cleanup, and maintain rtl support.
@nloureiro or @konopkja do you mind taking a look at this from design side. Dev side this is fine.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BUGFIX: Resolves a visual layout issue where a significant whitespace gap appeared below the site footer.
Description
The "FeedbackWidget" was using
position: stickyrelative to the document flow. Being the last element in the DOM, the browser reserved physical space for it at the very bottom of the page, extending the scrollable area unnecessarily and making the footer have a big gap.Screenshot
Before:
After:
Fix:
FixedDotcomponent fromstickytofixed.me-4 ms-auto) to coordinate-based (right-4).This change removes the widget from the document flow entirely, allowing it to float above the content without affecting the page height or layout boundaries.
Testing