perf: optimize ProductTable filter rendering to reduce INP on mobile #16694
+285
−106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ther filter updates
pettinarip
requested review from
corwintines,
minimalsm and
wackerow
as code owners
✅ Deploy Preview for ethereumorg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
pettinarip
force-pushed
the
find-wallets-optimizations
branch
from
084248b to
16973e2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Performance improvements to wallet/product filtering, targeting significant INP reduction on mid/low-tier mobile devices.
memo()to skip re-renders when filter state hasn't meaningfully changedstartTransitionand useuseDeferredValuefor smoother UX<PersistentPanel>component that stays mounted after first open (avoids expensive re-renders of filter content).filter()into single pass over wallet dataThese changes reduce jank when toggling filters, especially on mobile where the filter panel was previously re-mounting its entire content on each open.
INP improvements in (mid/low tier phones simulations):