core: turn gas into a vector <regularGas, stateGas>#34691
Open
MariusVanDerWijden wants to merge 3 commits intoethereum:masterfrom
Open
core: turn gas into a vector <regularGas, stateGas>#34691MariusVanDerWijden wants to merge 3 commits intoethereum:masterfrom
MariusVanDerWijden wants to merge 3 commits intoethereum:masterfrom
Conversation
jwasinger
reviewed
Apr 9, 2026
|
|
||
| import "fmt" | ||
|
|
||
| type GasCosts struct { |
Contributor
There was a problem hiding this comment.
Need descriptor comments for this struct and the String method.
jwasinger
reviewed
Apr 9, 2026
Contributor
jwasinger
left a comment
jwasinger
left a comment
There was a problem hiding this comment.
LGTM other than the small nitpick I mentioned
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pre-refactor PR to get 8037 upstreamed in chunks