simulators/ethereum/sync: reduce finalized block distance to zero #1367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the
ethereum/synctest waits for the other peer to sync to head block.However, the other peer only syncs to latest finalized block.
This test will therefore never pass if the latest finalized block is not the head block.
This was not a problem until this commit 8d692b4 introduced a finalized distance of fifty.
Hence, the solution is to reduce the finalized distance to zero.
This change matches the original behavior of the test before it started failing for most of the clients.