Updated ASET #122
Open
wateriousmelon2333 wants to merge 13 commits into
Open
Conversation
wateriousmelon2333
commented
Nov 7, 2025
Contributor
- Fixed ASET bug, now fragment allows atoms with more than 1 letter.
- Updated ASET so it can run on AVAS projected orbitals, prior to CASSCF.
- Updated McOptimizer so mix_inactive is false when parent method is ASET.
- Added one test case.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the ASET (Active Space Embedding Theory) implementation to support multi-letter atomic symbols, enable execution on AVAS-projected orbitals, and improve orbital optimization behavior. The key changes include:
- Fixed regex pattern to properly handle atoms with 1-2 letter symbols (e.g., "Li", "Cl")
- Extended ASET to accept AVAS as a parent method in addition to MCOptimizer
- Updated MCOptimizer to disable inactive orbital mixing when parent method is ASET
- Added test case demonstrating the AVAS→ASET→CASSCF workflow
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| tests/orbitals/test_aset.py | Added AVAS import and new test case for AVAS→ASET→CASSCF workflow |
| tests/orbitals/reference_aset_orbitals/test_aset_6_orbitals.npy | Reference orbital data for new test case |
| forte2/orbitals/aset.py | Updated fragment parsing regex, added AVAS support, new compute_g1_sf method, removed unused import |
| forte2/mcopt/mc_optimizer.py | Added ASET import, conditional mix_inactive logic, fixed typo in comment |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
wateriousmelon2333
force-pushed
the
update-aset
branch
2 times, most recently
from
January 21, 2026 16:55
91cc199 to
2addfb1
Compare
2. Updated ASET so it can run on AVAS projected orbitals, prior to CASSCF. 3. Updated McOptimizer so mix_inactive is false when parent method is ASET. 4. Added one test case.
2. Updated ASET so it can run on AVAS projected orbitals, prior to CASSCF. 3. Updated McOptimizer so mix_inactive is false when parent method is ASET. 4. Added one test case.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
wateriousmelon2333
force-pushed
the
update-aset
branch
from
April 2, 2026 18:35
b8eeabc to
59eca3e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #122 +/- ##
==========================================
- Coverage 94.08% 92.98% -1.10%
==========================================
Files 150 150
Lines 12988 13006 +18
Branches 1008 1011 +3
==========================================
- Hits 12220 12094 -126
- Misses 534 676 +142
- Partials 234 236 +2 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.