This repository was archived by the owner on Mar 5, 2025. It is now read-only.
Adds Tab/section progress indicators#61
Open
kspanier2013 wants to merge 2 commits intoevansloan:masterfrom
Open
Adds Tab/section progress indicators#61kspanier2013 wants to merge 2 commits intoevansloan:masterfrom
kspanier2013 wants to merge 2 commits intoevansloan:masterfrom
Conversation
Contributor
Author
|
@evansloan It's been a while on this one. Is it worth fixing conflicts? Or consider the feature a no-go? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #45
Adds colored indicators to tabs and sections, showing the areas that are in-progress.
The counts on the tab will be the number of uniques, not total if there are shared items in different sections.
Original issue in #45 only dances around the idea of the indicators on tabs, unsure if it's what we want. I've implemented it in a separate commit so we can easily roll it back if we decide it's not the route we want to go.
The code for getting uniques in the tab is not as DRY as I'd like, but I couldn't think of a good way to refactor since it has different inner logic than the total unique finder.
Examples:
