Conversation
There was a problem hiding this comment.
Pull request overview
This PR introduces support for ESI Dogma Attribute endpoints via the Client resources interface, along with new/updated models and refreshed VCR fixtures/specs to validate the behavior.
Changes:
- Implement
client.dogmawithDogmaResources#attributesand#attribute. - Add
Models::DogmaAttributesandModels::DogmaAttributeShort; expandModels::DogmaAttributeto represent full attribute details. - Update VCR cassettes and feature specs for dogma attributes; adjust
Models::Type#dogma_attributesto useDogmaAttributeShort.
Reviewed changes
Copilot reviewed 18 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| spec/fixtures/vcr_cassettes/esi/dogma/attributes/2.yml | Updated recorded request/response for fetching a single dogma attribute. |
| spec/fixtures/vcr_cassettes/esi/dogma/attributes.yml | Updated recorded request/response for listing dogma attribute IDs. |
| spec/features/dogma_attributes_spec.rb.old | Removed legacy feature spec (old interface). |
| spec/features/dogma_attributes_spec.rb | Added feature spec covering client.dogma.attributes and parsed headers. |
| spec/features/dogma_attribute_spec.rb.old | Removed legacy feature spec (old interface). |
| spec/features/dogma_attribute_spec.rb | Added feature spec covering client.dogma.attribute and parsed headers. |
| spec/eve_online/esi/models/dogma_attribute_short_spec.rb.old | Removed legacy model spec for the old DogmaAttributeShort implementation. |
| spec/eve_online/esi/dogma_attributes_spec.rb.old | Removed legacy unit spec for removed/legacy DogmaAttributes API wrapper. |
| spec/eve_online/esi/dogma_attribute_spec.rb.old | Removed legacy unit spec for removed/legacy DogmaAttribute API wrapper. |
| lib/eve_online/esi/resources/dogma_resources.rb | New Dogma resource implementing attribute list and attribute detail calls. |
| lib/eve_online/esi/models/type.rb | Switch dogma_attributes collection items to DogmaAttributeShort. |
| lib/eve_online/esi/models/dogma_attributes.rb | New model wrapper for dogma attribute ID list responses. |
| lib/eve_online/esi/models/dogma_attribute_short.rb.old | Removed legacy model file. |
| lib/eve_online/esi/models/dogma_attribute_short.rb | New short model compatible with ESI::Object (attributes.*). |
| lib/eve_online/esi/models/dogma_attribute.rb | Update model JSON shape to full attribute details (not the short {attribute_id,value} form). |
| lib/eve_online/esi/dogma_attributes.rb | Removed legacy DogmaAttributes API wrapper. |
| lib/eve_online/esi/client.rb | Implement #dogma to return Resources::DogmaResources. |
| lib/eve_online.rb | Autoload DogmaResources, DogmaAttributes, and DogmaAttributeShort. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 22 out of 22 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
| # Dogma APIs | ||
| def dogma | ||
| raise NotImplementedError, "Dogma API is not implemented yet" | ||
| Resources::DogmaResources.new(self) | ||
| end |
There was a problem hiding this comment.
Client#dogma is now implemented and returns Resources::DogmaResources, but the README still documents the legacy EveOnline::ESI::DogmaAttributes/DogmaEffects API classes (and EveOnline::ESI::DogmaAttributes appears to have been removed in this PR). Please update the public documentation (and, if this is a breaking API removal, consider providing a deprecation path or bumping the major version / changelog entry).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 23 out of 23 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
README.md:981
- The README Dogma “Get attributes” example still instantiates
EveOnline::ESI::DogmaAttributes, but that class was removed (Dogma APIs are now accessed viaEveOnline::ESI::Client#dogma). This snippet will raise aNameErrorand the example outputs (size/first) are also out of date; please update the README example to useclient.dogma.attributes(and remove the extra blank lines at the start of the code block).
```ruby
dogma_attributes = EveOnline::ESI::DogmaAttributes.new
dogma_attributes.scope # => nil
dogma_attributes.attribute_ids.size # => 2469
dogma_attributes.attribute_ids.first # => 2
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
No description provided.