Skip to content

Conversation

wataruoguchi
Copy link
Contributor

@wataruoguchi wataruoguchi commented Oct 1, 2025

Problem

I want to use non-default partition names. When I configure the partition name in HandleOptions, I expect that messages and streams respect that value and set it to "partition", rather than using the default partition name "default_partition". - And they do.

However, when reading the streams via aggregateStream, it tries to use the default partition name. After investigation, I noticed aggregateStream internally uses readStream and the readStream does not have the partition option passed through HandleOptions. This is because aggregateStream selectively sets HandleOptions when it's calling readStream.

Solution

To maintain consistency, I propose passing the handleOptions to the "read" property, so the aggregateStream calls readStream with the expected options.

@oskardudycz
Copy link
Collaborator

Hey @wataruoguchi, it was intentional to take only what's actually used in read, not to pass something accidentally. However, it may make it risky to omit some optional parameters.

Thanks for the contribution, I'll pull that in 🙂

Also, FYI, partition is not yet used. The table structure is prepared for it, but for now, just using the default partition. In the next releases, there will be more around it 🙂

@oskardudycz oskardudycz merged commit a8a9927 into event-driven-io:main Oct 3, 2025
1 of 3 checks passed
@wataruoguchi
Copy link
Contributor Author

Amazing! Thank you for pulling it in! Please also publish the npm package when you have a chance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants