[#fix] Pass handleOptions to 'read' which is consumed by readStream #265
+1
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
I want to use non-default partition names. When I configure the partition name in
HandleOptions
, I expect that messages and streams respect that value and set it to "partition", rather than using the default partition name "default_partition". - And they do.However, when reading the streams via
aggregateStream
, it tries to use the default partition name. After investigation, I noticedaggregateStream
internally usesreadStream
and thereadStream
does not have the partition option passed throughHandleOptions
. This is becauseaggregateStream
selectively setsHandleOptions
when it's callingreadStream
.Solution
To maintain consistency, I propose passing the handleOptions to the "read" property, so the
aggregateStream
callsreadStream
with the expected options.