expose java Kafka producer metrics#641
Conversation
| metrics(clientId) | ||
| } | ||
| KafkaProducerOf[F](producerMetrics) | ||
| val prefix = clientIdOf(config.journal.kafka.consumer.common) |
There was a problem hiding this comment.
client ID is already included in the generated labels
There was a problem hiding this comment.
in what kind of labels the ID is already included?
There was a problem hiding this comment.
Please try to run it locally - client_id is already included in the labels generated by the collector.
I suspect if you generate the prefix this way, it won't even mention that those are "kafka producer" metrics.
| } | ||
| KafkaProducerOf[F](producerMetrics) | ||
| val prefix = clientIdOf(config.journal.kafka.consumer.common) | ||
| KafkaProducerOf.apply1[F](prefix, producerMetrics) |
There was a problem hiding this comment.
there should be a way to disable producer metrics without disabling overall journal metrics
There was a problem hiding this comment.
why should the metrics be so configurable? I see not much sense in it
There was a problem hiding this comment.
If they name clash with other things, it's good to be able to disable them.
Pull Request Test Coverage Report for Build 9874635831Details
💛 - Coveralls |
|
The PR must be re-implemented after evolution-gaming/skafka#430 will be merged. New |
3 participants
No description provided.