Skip to content

update Kafka client to 4.2.0#484

Open
mr-git wants to merge 20 commits intomasterfrom
m/update-kafka-client-to-4.0.0
Open

update Kafka client to 4.2.0#484
mr-git wants to merge 20 commits intomasterfrom
m/update-kafka-client-to-4.0.0

Conversation

@mr-git
Copy link
Copy Markdown
Contributor

@mr-git mr-git commented Apr 9, 2025

  • update kafka-clients to v4.2.0
  • remove functions deprecated before kafka-clients v4
  • drop Scala 2.12 support
  • discard RebalanceListener
  • remove SerialListeners and related code (was used to support RebalanceListener)

@mr-git mr-git marked this pull request as draft April 9, 2025 17:38
compressionType = CompressionType.Lz4,
retries = 8,
maxInFlightRequestsPerConnection = 7,
partitionerClass = Some(classOf[DefaultPartitioner]),
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this something related to changes in java kafka-clients model? I tried to find the corresponding change to ProducerConfig in this changeset but I couldn't

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

other option would be to use RoundRobinPartitioner (the only implementation of Partitioner) - not sure, if that is a better choice.

@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

@mr-git mr-git force-pushed the m/update-kafka-client-to-4.0.0 branch from 7d20965 to 906dd27 Compare April 7, 2026 12:35
@coveralls
Copy link
Copy Markdown

coveralls commented Apr 7, 2026

Coverage Report for CI Build 25173261031

Coverage increased (+3.3%) to 79.88%

Details

  • Coverage increased (+3.3%) from the base build.
  • Patch coverage: 1 uncovered change across 1 file (8 of 9 lines covered, 88.89%).
  • 160 coverage regressions across 28 files.

Uncovered Changes

File Changed Covered %
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/RebalanceConsumer.scala 4 3 75.0%

Coverage Regressions

160 previously-covered lines in 28 files lost coverage.

Top 10 Files by Coverage Loss Lines Losing Coverage Coverage
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerLogging.scala 27 87.02%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/ConsumerMetrics.scala 21 40.12%
skafka/src/main/scala/com/evolutiongaming/skafka/KafkaHealthCheck.scala 16 60.29%
modules/metrics_prometheus_v1/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetricsOf.scala 14 0.0%
modules/metrics/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetricsOf.scala 14 0.0%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerLogging.scala 14 44.0%
skafka/src/main/scala/com/evolutiongaming/skafka/consumer/Consumer.scala 13 82.79%
skafka/src/main/scala/com/evolutiongaming/skafka/producer/ProducerMetrics.scala 13 42.03%
modules/metrics_prometheus_v1/src/main/scala/com/evolutiongaming/skafka/metrics/KafkaMetricsCollector.scala 4 5.71%
skafka/src/main/scala/com/evolutiongaming/skafka/Converters.scala 3 91.8%

Coverage Stats

Coverage Status
Relevant Lines: 2669
Covered Lines: 2132
Line Coverage: 79.88%
Coverage Strength: 1.25 hits per line

💛 - Coveralls

@mr-git mr-git changed the title update Kafka client to 4.0.0 update Kafka client to 4.2.0 Apr 7, 2026
@mr-git mr-git force-pushed the m/update-kafka-client-to-4.0.0 branch from 0197c5e to a7a2424 Compare April 30, 2026 14:58
@mr-git mr-git marked this pull request as ready for review April 30, 2026 14:59
@mr-git mr-git requested a review from Z1kkurat April 30, 2026 14:59
@sonarqubecloud
Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants